https://gitlab.synchro.net/main/sbbs/-/commit/b5b3769123c99c8500377ebc
Modified Files:
src/sbbs3/ssl.c
Log Message:
Don't set cryptlib_initialized = true until the init is complete

is_crypt_initialized() does not depend on the once value.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fea518c7ae55a66649a81068
Modified Files:
src/sbbs3/ssl.c
Log Message:
assert() pthread_mutex assumptions in ssl.c
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2adf8468d63418b04cef9c2d
Modified Files:
src/sbbs3/ssl.c
Log Message:
Log a (notice-level) message when creating a self-signed cert
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3122a36b6b0bad4296401ab3
Modified Files:
src/sbbs3/ssl.c
Log Message:
Fix failure handing in crypt initialization.

Don't add the atexit() do_cryptEnd() handler until we're not going
to call cryptEnd() ourselves.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d1c741d07362a4a3327532f7
Modified Files:
src/sbbs3/ssl.c
Log Message:
Incremental backoff on loading SSL cert

Try for 16 seconds (14 loops) to load the SSL certificate.

On the first time through the loop, create self-signed certificate
if configured to do so.

This also splits the generation of the self-signed certificate into
a separate function.

While we're here, split the new SSL epoch out into a separate function
as well, and explicitly call it when we create a new self-signed
cert. This at least partially fixes the epoch thing, but there's
still the possibility of creating it multiple times in the same
second... the file date isn't really enough.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1d0353858e00d5fade270854
Modified Files:
src/sbbs3/ssl.c
Log Message:
Better error reporting/handling when the ssl.cert file doesn't exist

Since "Create self-signed certificate" defaults to No, it's normal/expected to not have an ssl.cert file in many cases and the logged errors were not very helpful. We should probably change the default for this setting to Yes
(and have letsyncrypt.js disable it) or when auto-disable any SSH/TLS functionality that will expect a certificate file when the file doens't exist during initialization (startup or recycle). At least this change is a little bit of an improvement (help to the unknowing sysop). No longer just logging this unhelpful spew:
7/8 21:23:05 mail 0055 SEND connecting to port 25 on mail.synchro.net [71.95.196.36]
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:06 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:07 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:08 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:10 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:14 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:22 mail Failed to open/read TLS certificate: /sbbs/ctrl/ssl.cert
7/8 21:23:22 mail 0055 SEND/TLS [mail.synchro.net] ERROR 'Data has not been initialised' (-11) setting private key

Thanks to Sam Alexander (BLUEBOX) for pointing this bad behavior out.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net